ivo/ponzi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

In the call() method, the exception wasn't being thrown if only 1 or more than 2 arguments were passed to the method. Fixed conditional statement to only accept exactly 2 arguments.

Browse Source 
In the route() method, URI::current() was evaluating as '/' in all situations. It was never evaluating as the route that you specified when executing the command. This could be part of a larger underlying bug with Symfony's HttpFoundation\Request class. It might be a band-aid fix, but replacing URI::current() with $_SERVER['REQUEST_URI'] allows the method to run the correct route.
These fixes uncovered what I believe is potentially another bug. When var_dump($route->response()) is run, "NULL" and a newline is appended to the output. It's something to do with var_dump(), as echo $route->response() echo's the correct output without the extra "NULL".

Signed-off-by: Jakobud <jake.e.wilson@gmail.com>
This commit is contained in:
Jakobud
2012-07-26 16:00:46 -06:00
parent 5c3ede74d9
commit 433318181b
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
laravel/cli/tasks/route.php
View File

@@ -14,7 +14,7 @@ class Route extends Task {
*/ */
public function call($arguments = array()) public function call($arguments = array())
{ {
if ( ! count($arguments) == 2) if ( count($arguments) != 2)
{ {
throw new \Exception("Please specify a request method and URI."); throw new \Exception("Please specify a request method and URI.");
} }
@@ -41,7 +41,7 @@ class Route extends Task {
// We'll call the router using the method and URI specified by // We'll call the router using the method and URI specified by
// the developer on the CLI. If a route is found, we will not // the developer on the CLI. If a route is found, we will not
// run the filters, but simply dump the result. // run the filters, but simply dump the result.
$route = Router::route(Request::method(), URI::current()); $route = Router::route(Request::method(), $_SERVER['REQUEST_URI']);
if ( ! is_null($route)) if ( ! is_null($route))
{ {
@@ -53,4 +53,4 @@ class Route extends Task {
} }
} }
} }