final code cleanup

This commit is contained in:
Taylor Otwell
2012-02-16 13:59:48 -06:00
parent f41717dcb1
commit 49d9666958
3 changed files with 33 additions and 22 deletions

View File

@@ -31,29 +31,40 @@ class Cookie {
{
if (headers_sent()) return false;
// All cookies are stored in the "jar" when set and not sent directly to
// the browser. This simply makes testing all of the cookie stuff very
// easy since the jar can be inspected by the tests.
// All cookies are stored in the "jar" when set and not sent directly to the
// browser. This simply makes testing all of the cookie stuff very easy
// since the jar can be inspected by the tests.
foreach (static::$jar as $cookie)
{
extract($cookie);
$time = ($minutes !== 0) ? time() + ($minutes * 60) : 0;
// A cookie payload can't exceed 4096 bytes, so if the payload is greater
// than that, we'll raise an error to warn the developer since it could
// cause serious session problems.
$value = static::sign($name, $value);
if (strlen($value) > 4000)
{
throw new \Exception("Payload too large for cookie.");
}
setcookie($name, $value, $time, $path, $domain, $secure);
static::set($cookie);
}
}
/**
* Send a cookie from the cookie jar back to the browser.
*
* @param array $cookie
* @return void
*/
protected static function set($cookie)
{
extract($cookie);
$time = ($minutes !== 0) ? time() + ($minutes * 60) : 0;
// A cookie payload can't exceed 4096 bytes, so if the payload is greater
// than that, we'll raise an error to warn the developer since it could
// cause serious cookie-based session problems.
$value = static::sign($name, $value);
if (strlen($value) > 4000)
{
throw new \Exception("Payload too large for cookie.");
}
setcookie($name, $value, $time, $path, $domain, $secure);
}
/**
* Get the value of a cookie.
*