ivo/ponzi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improving laravel relationship performance

Browse Source
This commit is contained in:
Vinícius Fragoso
2012-10-05 10:35:48 -03:00
parent 4f8a6724b0
commit f36446bd10
4 changed files with 40 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
laravel/database/eloquent/relationships/belongs_to.php
View File

@@ -87,16 +87,17 @@ class Belongs_To extends Relationship {
{ {
$foreign = $this->foreign_key(); $foreign = $this->foreign_key();
foreach ($children as &$child) $parents_hash = array();
foreach ($parents as $parent)
{ {
$parent = array_first($parents, function($k, $v) use (&$child, $foreign) $parents_hash[$parent->get_key()] = $parent;
{ }
return $v->get_key() == $child->$foreign;
});
if ( ! is_null($parent)) foreach ($children as $child)
{
if (array_key_exists($child->$foreign, $parents_hash))
{ {
$child->relationships[$relationship] = $parent; $child->relationships[$relationship] = $parents_hash[$child->$foreign];
} }
} }
} }

16
laravel/database/eloquent/relationships/has_many.php
View File

@@ -91,14 +91,18 @@ class Has_Many extends Has_One_Or_Many {
{ {
$foreign = $this->foreign_key(); $foreign = $this->foreign_key();
foreach ($parents as &$parent) $children_hash = array();
foreach ($children as $child)
{ {
$matching = array_filter($children, function($v) use (&$parent, $foreign) $children_hash[$child->$foreign][] = $child;
{ }
return $v->$foreign == $parent->get_key();
});
$parent->relationships[$relationship] = array_values($matching); foreach ($parents as $parent)
{
if (array_key_exists($parent->get_key(), $children_hash))
{
$parent->relationships[$relationship] = $children_hash[$parent->get_key()];
}
} }
} }

16
laravel/database/eloquent/relationships/has_many_and_belongs_to.php
View File

@@ -328,14 +328,18 @@ class Has_Many_And_Belongs_To extends Relationship {
{ {
$foreign = $this->foreign_key(); $foreign = $this->foreign_key();
foreach ($parents as &$parent) $children_hash = array();
foreach ($children as $child)
{ {
$matching = array_filter($children, function($v) use (&$parent, $foreign) $children_hash[$child->pivot->$foreign][] = $child;
{ }
return $v->pivot->$foreign == $parent->get_key();
});
$parent->relationships[$relationship] = array_values($matching); foreach ($parents as $parent)
{
if (array_key_exists($parent->get_key(), $children_hash))
{
$parent->relationships[$relationship] = $children_hash[$parent->get_key()];
}
} }
} }

17
laravel/database/eloquent/relationships/has_one.php
View File

@@ -38,14 +38,21 @@ class Has_One extends Has_One_Or_Many {
{ {
$foreign = $this->foreign_key(); $foreign = $this->foreign_key();
foreach ($parents as &$parent) $children_hash = array();
foreach ($children as $child)
{ {
$matching = array_first($children, function($k, $v) use (&$parent, $foreign) if (array_key_exists($child->pivot->$foreign, $children_hash))
{ {
return $v->$foreign == $parent->get_key(); continue;
}); }
$parent->relationships[$relationship] = $matching; $children_hash[$child->pivot->$foreign] = $child;
}
foreach ($parents as $parent)
{
if (array_key_exists($parent->get_key(), $children_hash))
$parent->relationships[$relationship] = $children_hash[$parent->get_key()];
} }
} }